Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73188 )
Change subject: sb/amd/pi/hudson/fadt: drop unneeded ARM_boot_arch assignment ......................................................................
sb/amd/pi/hudson/fadt: drop unneeded ARM_boot_arch assignment
The FADT data structure is zero-initialized in acpi_create_fadt which then calls the SoC-specific acpi_fill_fadt function, therefore it's not needed to assign 0 to the ARM_boot_arch FADT field in acpi_fill_fadt.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Id2d24a9b8d5b04271eb4da6a622b5bba66dbc501 --- M src/southbridge/amd/pi/hudson/fadt.c 1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/73188/1
diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c index 027ed78..4989d6b 100644 --- a/src/southbridge/amd/pi/hudson/fadt.c +++ b/src/southbridge/amd/pi/hudson/fadt.c @@ -62,8 +62,6 @@ ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON;
- fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0;