Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
I just checked the VCM datasheet and I'd have to check the board and module schematics (would be nic […]
We need to go to SSDT anyway so can we leave DSDT as for now without adding a guard variable?
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 347: If ((STA == Zero))
Looks like there is something wrong with indentation (spaces, no tabs) in all the code being added i […]
Done
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 366: Store(1,STA)
We're trying to move to ASL 2.0 syntax, so `STA = 1` will work here.
Done
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 386: Store(0,STA)
We're trying to move to ASL 2.0 syntax, so `STA = 0` will work here.
Done