[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
PS8, Line 232: int
> vb2_error_t

To be honest, I'm not sure if there's a point in using vb2_error_t, if the only return values being used are VB2_SUCCESS and VB2_UNKNOWN_ERROR.  Seems like a lot of functions are doing that.  If there are useful return values that could be bubbled up, we should add them to 2return_codes.h.  If not, maybe it doesn't make sense to use vb2_error_t.