Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Zhanzhan Ge has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31 ......................................................................
Patch Set 17:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83928/comment/007a92ad_3fdca2eb?usp... : PS8, Line 9: 1. Set systimer compensation to version 2.0. : 2. The system does not need to serve pending IRQ from systimer : after rebooting. Therefore we clear systimer IRQ pending bit : at early booting.
Can we have 2 separate patches for these? Item 1 looks like a fix to me, but item 2 seems like an im […]
Yes,
File src/soc/mediatek/mt8196/include/soc/timer.h:
https://review.coreboot.org/c/coreboot/+/83928/comment/be68526e_849dd2fc?usp... : PS8, Line 22: /* 0x0*/
Remove these comments, as there are already `check_member` below.
Done
File src/soc/mediatek/mt8196/timer_prepare.c:
https://review.coreboot.org/c/coreboot/+/83928/comment/bff4c3f8_ac29efa2?usp... : PS8, Line 18: &mtk_systimer->cnttval[id].con
Use a local variable for this pointer.
Hi, mtk_systimer is already a local variable, thank you
https://review.coreboot.org/c/coreboot/+/83928/comment/d2cd711e_ffaaa7f6?usp... : PS8, Line 28: clrbits32
`clrbits32p`
The difference between clrbits32 and clrbits32p is whether the first parameter is a pointer, so there should be no need to change it to clrbits32p. Thank you