Attention is currently required from: Cliff Huang, Jérémy Compostella.
Paul Menzel has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84718?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat: add pre-mem configuration based on fw_config ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84718/comment/79dc75fa_01217703?usp... : PS5, Line 9: is setup The verb is spelled with a space: is set up
https://review.coreboot.org/c/coreboot/+/84718/comment/4b03f8bd_090110cd?usp... : PS5, Line 15: Please mention the sources you used to implement this.
https://review.coreboot.org/c/coreboot/+/84718/comment/98c86e54_7e159b27?usp... : PS5, Line 17: TEST=Boot on google fatcat board Boot what? And everything was working?
File src/mainboard/google/fatcat/romstage.c:
https://review.coreboot.org/c/coreboot/+/84718/comment/2dcb2f44_fac0a547?usp... : PS5, Line 14: __weak void fw_config_configure_pre_mem_gpio(void) This function is not used in coreboot yet for other boards. Why model it this way?
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/84718/comment/919a67d9_fa9b3646?usp... : PS5, Line 17: step1 step 1
https://review.coreboot.org/c/coreboot/+/84718/comment/95c586ab_5d8c1c05?usp... : PS5, Line 95: WWAN datasheet Please add the name.