5 Jan
2024
5 Jan
'24
6:03 p.m.
Attention is currently required from: Jason Nien, Martin Roth, Raul Rangel.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email )
Change subject: mb/google/guybrush: Update DDI descriptor definition ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79793/comment/ee241967_fa6b5681 : PS3, Line 8: bootblock-y += variant.c
Surprised we need this in bootblock.
We definitely don't. Got a little copy/paste happy. I'll remove it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79793?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6
Gerrit-Change-Number: 79793
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Jan 2024 18:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment