Martin Roth has posted comments on this change. ( https://review.coreboot.org/18523 )
Change subject: mainboard/pcengines/apu2: Add LPC TPM support ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/18523/12/src/mainboard/pcengines/apu2/romsta... File src/mainboard/pcengines/apu2/romstage.c:
PS12, Line 96: : #if CONFIG_LPC_TPM Avoid the preprocessor #if if possible. You should use: if (IS_ENABLED(CONFIG_LPC_TPM))
But since you're selecting LPC_TPM, and it will always be on, you could even just skip the if if you wanted.