[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 )

Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common
......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/#/c/19759/20/src/soc/intel/common/block/gpio/gpi...
File src/soc/intel/common/block/gpio/gpio.c:

PS20, Line 123: PAD_CFG_BASE
> I believe this has to be provided by the SoC. It would be good to document

Since I am planning to represent a group within a community (as in SKL) also with the same struct pad_community, a fixed PAD_CFG_BASE will not work for groups within a community - so I will instead add a field inside struct pad_community for this - With this I think we can also address the big core groups and each group should be represented by a struct pad_community (should I change the name from  pad_community to pad_community_or_group ?)