build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69493 )
Change subject: packeteer 6500 ......................................................................
Patch Set 1:
(47 comments)
File src/mainboard/packeteer/6500/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/ba96033b_b479b247 PS1, Line 27: PIRQ_SIGNATURE, /* u32 signature */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/e0bc3271_63802a0f PS1, Line 27: PIRQ_SIGNATURE, /* u32 signature */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/d96f341c_f7487d21 PS1, Line 28: PIRQ_VERSION, /* u16 version */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/f7a73199_58267a84 PS1, Line 28: PIRQ_VERSION, /* u16 version */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/7ab879de_6cf29693 PS1, Line 29: 32 + 16 * CONFIG_IRQ_SLOT_COUNT,/* Max. number of devices on the bus */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/79dbbd4f_d2aacb64 PS1, Line 29: 32 + 16 * CONFIG_IRQ_SLOT_COUNT,/* Max. number of devices on the bus */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/5d8c3939_96f38ae5 PS1, Line 30: 0x00, /* Interrupt router bus */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/03b909b7_4eed2b5b PS1, Line 30: 0x00, /* Interrupt router bus */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/bc2a4581_2d0f21d6 PS1, Line 31: (0x07 << 3) | 0x0, /* Interrupt router dev */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/1a7d3c4f_2113ee06 PS1, Line 31: (0x07 << 3) | 0x0, /* Interrupt router dev */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/69c1b623_2911fcd3 PS1, Line 32: 0, /* IRQs devoted exclusively to PCI usage */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/e9a35c2b_2e977fce PS1, Line 32: 0, /* IRQs devoted exclusively to PCI usage */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/acecc9fa_f763d499 PS1, Line 33: 0x8086, /* Vendor */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/fef69bec_efba7b45 PS1, Line 33: 0x8086, /* Vendor */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/abc1ac5b_f4f48a5f PS1, Line 34: 0x122e, /* Device */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/f04f2b0f_491fc1e4 PS1, Line 34: 0x122e, /* Device */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/7631af45_65ee73c4 PS1, Line 35: 0, /* Miniport */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/6f5c1978_40fc6392 PS1, Line 35: 0, /* Miniport */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/a9d982bd_a786faaa PS1, Line 36: { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, /* u8 rfu[11] */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/1634d3d8_cf4012c7 PS1, Line 36: { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, /* u8 rfu[11] */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/88502107_3a71f3b9 PS1, Line 37: 0xBC, /* Checksum */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/842fcacb_9e6f1d76 PS1, Line 37: 0xBC, /* Checksum */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/e468cae9_247c81b8 PS1, Line 38: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/91d15d74_a42b6008 PS1, Line 38: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/23723358_3a919ef9 PS1, Line 39: // NONE code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/9a28f724_7f56d565 PS1, Line 40: //{ 0x00, (0x04 << 3) | 0x0, {{PIRQ_INT_D, PIRQ_IRQ_MASK}, {PIRQ_INT_A, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}}, 0x0, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/96122bfa_9ea5d460 PS1, Line 42: // Southbridge 82371 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/5524afdd_368b4c17 PS1, Line 43: { 0x00, (0x07 << 3) | 0x0, {{0x00, 0x0}, {0x00, 0x0}, {0x00, 0x0}, {PIRQ_INT_D, PIRQ_IRQ_MASK}}, 0x0, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/4f15b2c0_3e2a38aa PS1, Line 43: { 0x00, (0x07 << 3) | 0x0, {{0x00, 0x0}, {0x00, 0x0}, {0x00, 0x0}, {PIRQ_INT_D, PIRQ_IRQ_MASK}}, 0x0, 0x0 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/1a6543bd_7b96a51e PS1, Line 44: //{ 0x00, (0x01 << 3) | 0x0, {{PIRQ_INT_A, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_D, PIRQ_IRQ_MASK}}, 0x0, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/82469755_bfc8849f PS1, Line 46: // PCI slot (bottom) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/0d2368f4_8d1279bb PS1, Line 47: { 0x00, (0x11 << 3) | 0x0, {{PIRQ_INT_A, PIRQ_IRQ_MASK}, {PIRQ_INT_D, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}}, 0x1, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/c96edd5d_c3c206ea PS1, Line 47: { 0x00, (0x11 << 3) | 0x0, {{PIRQ_INT_A, PIRQ_IRQ_MASK}, {PIRQ_INT_D, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}}, 0x1, 0x0 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/7c4f4e0c_913b650d PS1, Line 49: // ETH0 (front panel left) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/144c95a3_94e18e00 PS1, Line 50: { 0x00, (0x0b << 3) | 0x0, {{PIRQ_INT_B, PIRQ_IRQ_MASK}, {0x00, 0x0}, {0x00, 0x0}, {0x00, 0x0}}, 0x0, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/6aebf95d_8eb3e078 PS1, Line 50: { 0x00, (0x0b << 3) | 0x0, {{PIRQ_INT_B, PIRQ_IRQ_MASK}, {0x00, 0x0}, {0x00, 0x0}, {0x00, 0x0}}, 0x0, 0x0 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/51d35803_f0493a01 PS1, Line 52: // ETH1 (front panel right) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/ee20c919_cf703716 PS1, Line 53: { 0x00, (0x0c << 3) | 0x0, {{PIRQ_INT_C, PIRQ_IRQ_MASK}, {0x00, 0x0}, {0x00, 0x0}, {0x00, 0x0}}, 0x0, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/b50aff2d_82a6bc17 PS1, Line 53: { 0x00, (0x0c << 3) | 0x0, {{PIRQ_INT_C, PIRQ_IRQ_MASK}, {0x00, 0x0}, {0x00, 0x0}, {0x00, 0x0}}, 0x0, 0x0 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/3a742fe7_72791f14 PS1, Line 55: // PCI slot (top) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/d102e31c_eeda732f PS1, Line 56: { 0x00, (0x12 << 3) | 0x0, {{PIRQ_INT_D, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}, {PIRQ_INT_A, PIRQ_IRQ_MASK}}, 0x2, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/7097b515_95cc6836 PS1, Line 56: { 0x00, (0x12 << 3) | 0x0, {{PIRQ_INT_D, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}, {PIRQ_INT_A, PIRQ_IRQ_MASK}}, 0x2, 0x0 }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/2be50538_bf3225c5 PS1, Line 58: // PCI slot (top) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/8fb0caa4_6fac5672 PS1, Line 59: //{ 0x01, (0x00 << 3) | 0x0, {{PIRQ_INT_D, PIRQ_IRQ_MASK}, {PIRQ_INT_C, PIRQ_IRQ_MASK}, {PIRQ_INT_B, PIRQ_IRQ_MASK}, {PIRQ_INT_A, PIRQ_IRQ_MASK}}, 0x1, 0x0 }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/f49530e4_12d5f8f4 PS1, Line 60: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/52bb1336_911ce581 PS1, Line 60: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163469): https://review.coreboot.org/c/coreboot/+/69493/comment/82348b6f_c1c62d32 PS1, Line 75: } void function return statements are not generally useful