[coreboot-gerrit] [S] Change in coreboot[main]: vc/google/chromeos: Enable eSOL config with libgfx and uGOP

[Jayvik Desai (Code Review)]

Attention is currently required from: Angel Pons, Dinesh Gehlot, Julius Werner, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rishika Raj, Subrata Banik.

Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )

Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP
......................................................................

Patch Set 30:

(5 comments)

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/83705/comment/4614e654_cdb7b45d?usp... :
PS29, Line 109: 	  criticial firmware updates on Chrome OS devices, particularly for
> > `'criticial' may be misspelled - perhaps 'critical'?` […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/83705/comment/b8b201b8_4f13f199?usp... :
PS29, Line 110:
> drop space

Acknowledged

https://review.coreboot.org/c/coreboot/+/83705/comment/f2e75a4a_a2b35983?usp... :
PS29, Line 112:
> drop one empty line (just one is enough)

Acknowledged

https://review.coreboot.org/c/coreboot/+/83705/comment/d2cecf3c_f039d449?usp... :
PS29, Line 115: 	  -FSP uGOP: Closed-source solution from Intel's Firmware Support
> one space to start with after `-`

Acknowledged

https://review.coreboot.org/c/coreboot/+/83705/comment/9ca15ecd_6a0bf93f?usp... :
PS29, Line 117: -
> same

Acknowledged