Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44563
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: Run pmc_set_acpi_mode() during .init in pmc_ops ......................................................................
soc/intel/jasperlake: Run pmc_set_acpi_mode() during .init in pmc_ops
pmc_set_acpi_mode will set EC SMI mask to 1 in the end. However google_chromeec_events_init will clear EC SMI mask. If google_chromeec_events_init is ran after pmc_set_acpi_mode, the EC SMI mask will be 0 in depthcharge and causes lidclose function not working. So, pmc_set_acpi_mode() should run after google_chromeec_events_init.
This code is mainly from CL:42677
BUG=b:16338215 TEST=Close lid in depthcharge and the dut can be shutdown on waddledoo.
Signed-off-by: Kane Chen kane.chen@intel.com Change-Id: I0f06e8b5da00eb05a34a6ce1de6d713005211c08 --- M src/soc/intel/jasperlake/pmc.c 1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/44563/2