26 Apr
2021
26 Apr
'21
3:31 p.m.
Attention is currently required from: Felix Singer, Nico Huber, Damien Zammit, Tristan Corrick, Alexander Couzens, Patrick Rudolph, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52672 )
Change subject: src: Retype option API to use unsigned integers ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/siemens/chili/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117817): https://review.coreboot.org/c/coreboot/+/52672/comment/4fafc50c_f5bdddb3 PS1, Line 29: const uint8_t ht = get_uint_option("hyper_threading", memupd->FspmConfig.HyperThreading); line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/52672
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3480e5cfc0ec90674def7ef0919e0b7ac5b19b3
Gerrit-Change-Number: 52672
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Tristan Corrick tristan@corrick.kiwi
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 26 Apr 2021 15:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment