Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support with interface tables
......................................................................
Patch Set 32:
(1 comment)
Please document which blobs are used to boot the platform, their names, if they need to be loaded at a specific address, where to get them, why you don't compress them, ....
https://review.coreboot.org/#/c/29967/32/src/soc/qualcomm/common/qclib.c
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/#/c/29967/32/src/soc/qualcomm/common/qclib.c@147
PS32, Line 147: _ddr_training, ssize, 0);
unrelated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 32
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Fri, 28 Jun 2019 06:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment