Attention is currently required from: Angel Pons, Maximilian Brune.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Looking at EDK2's UefiInternalFormRespresentation header, I had some ideas: - Should we have per-option help text? - Currently, I mark all options as RESET_REQUIRED. If it's likely some options won't require a reset to apply, can we add a flag? - Please add an `OPTION_TEXT`, so we can notify the user. For instance, boards might display "EEPROM corrupted, contact manufacturer" - When we think about dependencies between options, we should consider logical relationships - `suppressif X AND NOT Y` - Since there is also OR, maybe tag these and we'll process them in order - if necessary, we can provide a field(s) for equality operators. Another thing to consider behaviour if the dependencies fail - suppress, grayout or allow the behaviour to be determined? The last one adds more complexity.
There's a lot more that's possible, such as arithmetic, bitwise logic and shifts, 'casting' type operators (including string `TO_LOWER` and `TO_UPPER`), but these get harder to justify and I'd rather neither of us implement the entire IFR language