Attention is currently required from: Elyes Haouas, Patrick Georgi.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76850?usp=email )
Change subject: payloads/libpayload/drivers/usb/ehci_private: Use C99 flexible arrays
......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/drivers/usb/ehci_private.h:
PS1:
without having really looked into the details, it seems to me that this packed struct is used to access hardware registers, so moving around elements will probably break things
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76850?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec5bb3da8205326a43bba44630a8fcdcac651184
Gerrit-Change-Number: 76850
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 01 Aug 2023 13:55:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment