Attention is currently required from: Paul Fagerburg, Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43510 )
Change subject: tests: Add lib/bootmem-test test case
......................................................................
Patch Set 5:
(2 comments)
File tests/lib/bootmem-test.c:
https://review.coreboot.org/c/coreboot/+/43510/comment/7c3806e3_07f87f0e
PS2, Line 247: /* Below range covers two differently tagged regions */
Oops, you are right.
Done.
https://review.coreboot.org/c/coreboot/+/43510/comment/b212795a_a6037a30
PS2, Line 249: assert_int_equal(ret, 0);
As with memrange patchset - I want this to be pretty complete. […]
I extended this test by adding a few more cases that Julius was talking about. I also added a region starting at 0x0 to check correct handling of zero address.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1e539061ee5051d4158712a8a981a475ea7458a
Gerrit-Change-Number: 43510
Gerrit-PatchSet: 5
Gerrit-Owner: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Thu, 18 Mar 2021 14:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Jan Dabros
jsd@semihalf.com
Gerrit-MessageType: comment