Attention is currently required from: Jon Murphy.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62153 )
Change subject: mb/google/skyrim: Add ACPI configuration for USB ports
......................................................................
Patch Set 37:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62153/comment/05b8cf36_e4480add
PS37, Line 79: 2.3
should this be 2.3 or 2.0? i'd assume 2.0, since that's the first usb 2 port on this xhci controller, but i'm not 100% sure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1b05f190f25dca1566e1023011cc70c2d32f461
Gerrit-Change-Number: 62153
Gerrit-PatchSet: 37
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Comment-Date: Wed, 09 Mar 2022 18:39:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment