[coreboot-gerrit] [M] Change in coreboot[main]: soc/intel: Adapt crashlog IP to also support 64-bit

[Angel Pons (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Pratikkumar V Prajapati, Sowmya Aralguppe, Subrata Banik, Tarun.

Angel Pons has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email )

Change subject: soc/intel: Adapt crashlog IP to also support 64-bit
......................................................................

Patch Set 22:

(2 comments)

Patchset:

PS22:
> There were some discrepancies in the original implementation […]

It would be great if you could put fixes in a separate commit. Otherwise it is hard to know what is part of adding 64-bit support, what is a fix and what is a new bug.

File src/soc/intel/meteorlake/crashlog.c:

https://review.coreboot.org/c/coreboot/+/83106/comment/3d74b4c0_f809fdbe?usp... :
PS22, Line 355: 		if (!is_crashlog_data_valid(dw0))
> This is in line 343 . […]

`cur_offset` changes inside the loop, so this reads a different register every iteration