Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34344/3/src/mainboard/google/kukui/... PS3, Line 21: def_bool n The only purpose of this option is to guard the ones below, so you shouldn't create a new one for this. If you want to model differences between Kukui and Jacuzzi, you should create feature-specific Kconfigs for that inside the BOARD_GOOGLE_KUKUI_COMMON block. Take the GRU_HAS_xxx options in Gru as a template.
You could also make a KUKUI_BASEBOARD_JACUZZI analogous to GRU_BASEBOARD_SCARLET, however, you should only do this if there are really a lot of fundamental board layout differences on Jacuzzi (on Scarlet we did it because almost every I/O pin on the SoC changed) and you're planning to create a lot more variants that are modeled after Jacuzzi. It's sounds like you just have a handful of component changes here so I'd go with the per-feature Kconfigs, unless you'd need, say, more than 3 of them.