Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Varshit Pandya.
Hello Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83443?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Varshit Pandya, Code-Review+2 by Martin Roth, Verified+1 by build bot (Jenkins)
Change subject: soc/amd/*/root_complex: introduce and use domain_iohc_info struct ......................................................................
soc/amd/*/root_complex: introduce and use domain_iohc_info struct
Instead of implementing the functions get_iohc_misc_smn_base and get_iohc_fabric_id in the SoC code, move those functions to the common AMD code, and implement get_iohc_info in the SoC code that returns a pointer to and the size of a SoC-specific array of domain_iohc_info structs that contains the info needed by the common code instead. This allows to iterate over the domain_iohc_info structs which will be used in a later patch to find the PSP MMIO base address in both ramstage and smm.
TEST=Mandolin still boots and all non-PCI MIO resources are still reported to the resource allocator
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ifce3d2b540d14ba3cba36f7cbf248fb7c63483fe --- M src/soc/amd/cezanne/root_complex.c M src/soc/amd/common/block/include/amdblocks/root_complex.h M src/soc/amd/common/block/root_complex/Makefile.mk A src/soc/amd/common/block/root_complex/root_complex.c M src/soc/amd/genoa_poc/root_complex.c M src/soc/amd/glinda/root_complex.c M src/soc/amd/mendocino/root_complex.c M src/soc/amd/phoenix/root_complex.c M src/soc/amd/picasso/root_complex.c 9 files changed, 122 insertions(+), 93 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/83443/2