Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83731?usp=email )
Change subject: soc/intel/cannonlake: Use FSP MP Init by default when INTEL_TXT enabled ......................................................................
soc/intel/cannonlake: Use FSP MP Init by default when INTEL_TXT enabled
To get all CPU features programmed properly for Intel TXT we need to use FSP MP Init. Have not yet found a way to program the features correctly and not have the FSP lock the registers before coreboot can do something about it.
TEST=Boot Linux with tboot on Protectli VP4670 with TXT enabled
Change-Id: I0f57e97477b89d953e24d0657335b777f4eaa45d Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/83731/1
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 3aa06f4..cc04929 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -340,6 +340,13 @@ hex default 0x40000 # 256KB
+# To get all CPU features programmed properly for Intel TXT we need +# to use FSP MP Init. Have not yet found a way to program the features +# correctly and not have the FSP lock the registers before coreboot +# can do something about it. +config USE_INTEL_FSP_MP_INIT + default y if INTEL_TXT + config INTEL_GMA_BCLV_OFFSET default 0xc8258