Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Add Type-C IOM device ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake: Add Type-C IOM device Would be good to follow this up with some details on IOM such as below. Input Output Manager (IOM) is part of the Tiger Lake SoC that configures the Type-C Sub System (TCSS).
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@9 PS1, Line 9: IO Manageability Engine Intel Input Output Manager (IOM)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver refers to this memory resource for port operations. Separate paragraph about how the driver uses this would be helpful as well.
Input Output Manager (IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver
What is the name of that driver?
"Intel Input Output Manager (IOM) driver"
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@13 PS1, Line 13: : Remove?
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 136: Tiger Lake IO Manageability Engine Input Output Manager (IOM) driver
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */ one line?