Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection ......................................................................
Patch Set 7:
(1 comment)
Patch Set 7:
Patch Set 7:
(6 comments)
Looks like you are overdoing the original cosmetic change a bit? Please explain the problem you are trying to fix before putting any more work into it.
Patch set #5 looked rather good?
I did. Read the commit message ;)
Also, the platform detection now has been implemented in a more generic way that will make it possible to move this (and coreboot-native PCIe root port swapping, which is already being worked on) to the common section and make it available for other platforms.
and why is improving code quality a bad thing?
https://review.coreboot.org/c/coreboot/+/35763/7/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35763/7/src/include/device/pci_ids.... PS7, Line 2701: #define PCI_DEVICE_ID_INTEL_SPT_LP_LPC_MASK 0x001f
Why is the mask inverted?
because of brainf... will be fixed