[coreboot-gerrit] [L] Change in coreboot[main]: mb/lattepanda: Add support for LattePanda Mu

[KunYi Chen (Code Review)]

Attention is currently required from: Felix Held, Felix Singer, Martin L Roth, Nicholas Chin, Nicholas Sudsgaard, Paul Menzel.

KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83719?usp=email )

Change subject: mb/lattepanda: Add support for LattePanda Mu
......................................................................

Patch Set 10:

(8 comments)

File src/mainboard/lattepanda/mu/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/83719/comment/554bc4b8_d0ffe526?usp... :
PS10, Line 9: 	register "emmc_enable_hs400_mode" = "1"
> Move this setting below the emmc device from the devicetree.

Acknowledged.
okay, thanks

https://review.coreboot.org/c/coreboot/+/83719/comment/8513ec13_2c21dd0d?usp... :
PS10, Line 11: 	register "sata_salp_support" = "0"
> Settings are initialized with 0, please remove.

Acknowledged.
okay. remove it.
just reference src/mainboard/intel/adlrvp/devicetree_n.cb

https://review.coreboot.org/c/coreboot/+/83719/comment/3608fdd5_8d15d3a5?usp... :
PS10, Line 38: 	register "serial_io_gspi_cs_mode" = "{
             : 		[PchSerialIoIndexGSPI0] = 0,
             : 		[PchSerialIoIndexGSPI1] = 0,
             : 		[PchSerialIoIndexGSPI2] = 0,
             : 		[PchSerialIoIndexGSPI3] = 0,
             : 	}"
             : 
             : 	register "serial_io_gspi_cs_state" = "{
             : 		[PchSerialIoIndexGSPI0] = 0,
             : 		[PchSerialIoIndexGSPI1] = 0,
             : 		[PchSerialIoIndexGSPI2] = 0,
             : 		[PchSerialIoIndexGSPI3] = 0,
             : 	}"
> Settings are initialized with 0, please remove.

Acknowledged, 
remove all.
thanks

https://review.coreboot.org/c/coreboot/+/83719/comment/a8339656_4f2ea050?usp... :
PS10, Line 59: 	register "pch_hda_dsp_enable" = "1"
             : 	register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
             : 	register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
             : 	r
> Move these settings below the hda device from the devicetree.

Acknowledged

https://review.coreboot.org/c/coreboot/+/83719/comment/af0ee396_71c0b6a4?usp... :
PS10, Line 103: 				[3] = USB2_PORT_EMPTY,
> USB ports are disabled by default, remove.

Acknowledged, remove it.

https://review.coreboot.org/c/coreboot/+/83719/comment/e1915565_bae8abea?usp... :
PS10, Line 110: 				[0] = USB3_PORT_EMPTY,
              :
> Same here.

Acknowledged, remove it.

File src/mainboard/lattepanda/mu/spd/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/83719/comment/a42b8fd7_bcf8b785?usp... :
PS10, Line 7: SPD_SOURCES += empty		# 0b004
> This seems odd. […]

Okay, I was just referencing src/mainboard/intel/adlrvp/spd/Makefile.mk
After testing, it seems unnecessary.

File src/mainboard/lattepanda/mu/spd/empty.spd.hex:

PS10:
> Why is a zeroed SPD file needed?

Acknowledged, remove it