Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68819 )
Change subject: mb/google/hatch: Kohaku - invoke power cycle of FPMCU on startup ......................................................................
Patch Set 11:
(5 comments)
This change is ready for review.
File src/mainboard/google/hatch/variants/kohaku/ramstage.c:
https://review.coreboot.org/c/coreboot/+/68819/comment/153226e2_4e27cb62 PS10, Line 11: size_t variant_gpios;
trailing whitespace
Please fix.
https://review.coreboot.org/c/coreboot/+/68819/comment/6e3f7d53_e8b9f9ae PS10, Line 12:
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/68819/comment/abf163b1_83c8d685 PS10, Line 12:
trailing whitespace
Please fix.
https://review.coreboot.org/c/coreboot/+/68819/comment/88a8599b_1d0665ec PS10, Line 18: *
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/68819/comment/44b1a4e1_dc7cbe2d PS10, Line 19: * Aftwards, finalize remaining GPIOs
code indent should use tabs where possible
Please fix.