Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig
File src/drivers/intel/fsp1_0/Kconfig:
https://review.coreboot.org/#/c/33453/1/src/drivers/intel/fsp1_0/Kconfig@a94
PS1, Line 94:
If a custom FMD file is provided, this kind of stays true.
rephrase as 'Your FMAP must contain a region named "RW_MRC_CACHE"'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33453
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa1da6015c1bfafe8ea81ca34ef8851f0c689487
Gerrit-Change-Number: 33453
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Jun 2019 19:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment