Attention is currently required from: Meera Ravindranath, Sridhar Siricilla, Patrick Rudolph. Meera Ravindranath has uploaded a new patch set (#9) to the change originally created by Krishna P Bhat D. ( https://review.coreboot.org/c/coreboot/+/48472 )
Change subject: southbridge/intel: Update top swap block size using ifdtool option ......................................................................
southbridge/intel: Update top swap block size using ifdtool option
Currently the INTEL_TOP_SWAP_BOOTBLOCK_SIZE is used in the context of cbfstool/ifittool to add top swap boot block and update fit pointers. The top-swap size definition is in 2 places i.e., descriptor and Kconfig, which will have to be aligned by the developer and can be missed. To address this issue, use the option (-j) added in ifdtool to set the top-swap size to whatever value is specified by INTEL_TOP_SWAP_BOOTBLOCK_SIZE.
BUG=None BRANCH=None TEST=emerge-dedede coreboot chromeos-bootimage. When INTEL_TOP_SWAP_BOOTBLOCK_SIZE=0x10000, cbfstool image-drawcia.bin print -r COREBOOT ... bootblock 0x3d7fc0 bootblock 131072 none
hexdump image-drawcia.bin.new 0000140 0000 c880 8645 0600 0000 0000 0204 0058
When INTEL_TOP_SWAP_BOOTBLOCK_SIZE=0x20000, cbfstool image-drawcia.bin print -r COREBOOT ... bootblock 0x3d7fc0 bootblock 262144 none
hexdump image-drawcia.bin.new 0000140 0010 c880 8645 0600 0000 0000 0204 0058
Change-Id: Ibd13c36d5754778db2f8996dbd5aa681f28bbb6c Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com --- M src/southbridge/intel/common/firmware/Makefile.inc 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/48472/9