Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83233?usp=email )
Change subject: soc/intel/cmn/cse: Conditionally disable ME status reporting ......................................................................
soc/intel/cmn/cse: Conditionally disable ME status reporting
This patch disables the ME status reporting functionality (dump_me_status, print_me_fw_version) in the CSE driver when SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD is defined.
This is likely intended for platforms or configurations where the CSE communication is only limited to payload.
BUG=b:305898363 TEST=Able to build google/rex.
Change-Id: I5e360408a7847968117df475ff244d79ceafa23f Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83233 Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Dinesh Gehlot digehlot@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_spec.c 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: Eric Lai: Looks good to me, but someone else must approve Nick Vaccaro: Looks good to me, approved build bot (Jenkins): Verified Dinesh Gehlot: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 32ca399..b278b9f 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -863,6 +863,9 @@
void print_me_fw_version(void *unused) { + if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD)) + return; + struct me_fw_ver_resp resp = {0};
/* Ignore if UART debugging is disabled */ diff --git a/src/soc/intel/common/block/cse/cse_spec.c b/src/soc/intel/common/block/cse/cse_spec.c index 74155cd..af64255 100644 --- a/src/soc/intel/common/block/cse/cse_spec.c +++ b/src/soc/intel/common/block/cse/cse_spec.c @@ -28,6 +28,9 @@
static void dump_me_status(void *unused) { + if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD)) + return; + union me_hfsts1 hfsts1; union me_hfsts2 hfsts2; union me_hfsts3 hfsts3;