Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36209 )
Change subject: security/vboot/sync_ec: Add timestamps
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync...
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36209/13/src/security/vboot/ec_sync...
PS13, Line 159: timestamp_add_now(TS_EC_HASH_READY);
Should we add it only when we return success? That will be consistent with other error scenarios whe […]
I figured leave it in, even if it returns the wrong type or doesn't finish, we'll have a timestamp saying it at least went through this path. Thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e5703c146b5ec27d01700fdb39cb3d2092ea8a8
Gerrit-Change-Number: 36209
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 22:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment