19 Jun
2024
19 Jun
'24
6:09 a.m.
Attention is currently required from: Andrey Petrov, Felix Singer, Julius Werner, Jérémy Compostella, Nico Huber, Ronak Kanabar.
Martin L Roth has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email )
Change subject: region: Introduce region_create() functions ......................................................................
Patch Set 7:
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/79905/comment/a95e5852_052a0bc5?usp... : PS7, Line 331: 1
I think Martin is referring to enum error values.
Right - I guess just CB_SUCCESS & CB_ERR.
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/main/src/c...
--
To view, visit https://review.coreboot.org/c/coreboot/+/79905?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b
Gerrit-Change-Number: 79905
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 19 Jun 2024 13:09:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com