[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add unmask eint event for bootblock

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )

Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock
......................................................................

Patch Set 14:

(1 comment)

File src/soc/mediatek/mt8196/eint_event.c:

https://review.coreboot.org/c/coreboot/+/84025/comment/9dfb139c_3e145a80?usp... :
PS14, Line 16: static void eint_clear_event_mask(uintptr_t base, unsigned int port_num)
> This function looks quite similar to the common `unmask_eint_event_mask`. […]

More precisely:

```
// common/eint_event.c

#define MASK_CLEAR_OFFSET 0x880
#define MASK_CLEAR_VALUE 0xFFFFFFFF

void eint_clear_event_mask(size_t port_num)
{
    int i;
    struct eint_event_reg *reg = (void *)(EINT_BASE + MASK_CLEAR_OFFSET);
    if (port_num == 0)
        port_num = ARRAY_SIZE(reg->eint_event_mask_clr);
    assert(port_num <= ARRAY_SIZE(reg->eint_event_mask_clr));
    for (i = 0; i < port_num; i++)
        write32(&reg->eint_event_mask_clr[i], MASK_CLEAR_VALUE);
}

void unmask_eint_event_mask(void)
{
    eint_clear_event_mask(0);
}

// mt8196/eint_event.c
void unmask_eint_event_mask(void)
{
    for (...)
        eint_clear_event_mask();
}
```

Does that make sense?