Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31762 )
Change subject: arch/x86/postcar: Add separate timestamp for postcar stage
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
this and the following patch could really be collapsed into one.
https://review.coreboot.org/#/c/31762/5/src/lib/prog_loaders.c
File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/31762/5/src/lib/prog_loaders.c@134
PS5, Line 134: timestamp_add_now(TS_END_ROMSTAGE);
Why not just fix this up in this patch instead of knowingly having bad timestamps here for romstage?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084f66949667ad598f811d4233b4e639bc4c113e
Gerrit-Change-Number: 31762
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 Mar 2019 15:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment