Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63254 )
Change subject: mb/starlabs/laptop: Enable rtd3 for SSD on TGL ......................................................................
mb/starlabs/laptop: Enable rtd3 for SSD on TGL
Enabling rtd3 reduces power consumption when the SSD is idle.
Tested and verified on the StarBook Mk V (TGL), using PowerTop on Manjaro 21.2.5 GNOME at 20% Brightness.
Signed-off-by: Stephen Edworthy stephen@starlabs.systems Change-Id: I0d8aa185a322bb8d1aba51ccaab03c521cec2770 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63254 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Sean Rhodes sean@starlabs.systems --- M src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Sean Rhodes: Looks good to me, approved
diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb index 66b8e86..6264257 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb @@ -182,6 +182,12 @@ register "PcieClkSrcClkReq[3]" = "3" register "PcieRpSlotImplemented[8]" = "1" smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X" + chip soc/intel/common/block/pcie/rtd3 + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "srcclk_pin" = "3" + device generic 0 on end + end end device pci 1d.1 off end # PCI Express Port 10 device pci 1d.2 off end # PCI Express Port 11
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.