[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Create a common PCH finalise implementation

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )

Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/29977/3/src/southbridge/intel/common/finaliz... 
File src/southbridge/intel/common/finalize.c:

https://review.coreboot.org/#/c/29977/3/src/southbridge/intel/common/finaliz... 
PS3, Line 75: outb(POST_OS_BOOT, CONFIG_POST_IO_PORT);
I would have preferred to use `post_code(POST_OS_BOOT)`, but
console/post.c isn't linked in SMM. Is there a reason why? It does
compile when I set it up that way. Though, I suppose less code in
SMM is a good thing...