Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix SKUID config for burnet/esche ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46442/2//COMMIT_MSG@7 PS2, Line 7: mb/google/kukui: fix SKUID config for burnet/esche : : ADCIN2 (LCM_ID) now was PD 200K but we might get incorrect voltage in : different condition: : developer mode : ADC[2]: Raw value=232459 ID=1 : : recovery mode: : ADC[2]: Raw value=36144 ID=0 : : in order to match sku definition of burnet/esche: : burnet: 0x11 : esche: 0x10 : : we'll need to bypass ADCIN2 to update SKUID accordingly. mb/google/kukui: fix LCMID to be 0x01 for Jacuzzi followers
The LCM ID is not really used on Jacuzzi followers and the ADC may return unexpected value on some boards, so we want to change that to a fixed value for all Jacuzzi followers.