21 Nov
2021
21 Nov
'21
7:04 p.m.
Attention is currently required from: Nick Vaccaro, Zhuohao Lee, Alan Huang. Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58241 )
Change subject: mb/google/brya/variants/brask: Set PL and PsysPL ......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/google/brya/variants/brask/ramstage.c:
https://review.coreboot.org/c/coreboot/+/58241/comment/9c30a251_6e4e04e8 PS12, Line 23: { PCI_DEVICE_ID_INTEL_ADL_P_ID_6, 15, 135, 135 }, The psys_pmax_power should be same (257W) for all SKUs. But seems the psys_pmax_power was not used in your implementation, is my understanding correct?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I183017068e9c78acb9fa7073c53593d304ba9248
Gerrit-Change-Number: 58241
Gerrit-PatchSet: 12
Gerrit-Owner: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-CC: Hou-hsun Lee hou-hsun.lee@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee zhuohao@google.com
Gerrit-Attention: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 03:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment