Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46644 )
Change subject: soc/intel/tigerlake: Add support for calling microcode update API
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46644/3/src/soc/intel/tigerlake/uco...
File src/soc/intel/tigerlake/ucode_update.c:
https://review.coreboot.org/c/coreboot/+/46644/3/src/soc/intel/tigerlake/uco...
PS3, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
None of this is tigerlake specific. Better move it somewhere else?
https://review.coreboot.org/c/coreboot/+/46644/3/src/soc/intel/tigerlake/uco...
PS3, Line 15: INTEL_TOP_SWAP_MULTI_FIT_UCODE_UPDATE
This is already been taken care of by the makefile inclusion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id60b9828498d1474193e238ec26da26ac322620e
Gerrit-Change-Number: 46644
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 28 Oct 2020 19:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment