Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45742 )
Change subject: mainboard/volteer: enable early tcss chrome ec related code in mainboard ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/45742/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45742/6/src/mainboard/google/voltee... PS6, Line 164: ret If you use my suggestions below, then `ret` can be deleted as well.
https://review.coreboot.org/c/coreboot/+/45742/6/src/mainboard/google/voltee... PS6, Line 167: ret = google_chromeec_get_num_pd_ports(&num_ports); : if (ret < 0) { : printk(BIOS_ERR, "get_num_pd_ports failed unable to continue\n"); : return; : } ``` if (google_chromeec_get_num_pd_ports(&num_ports) < 0) { printk(BIOS_ERR, "get_num_pd_ports failed unable to continue\n"); return; } ```
? ret isn't used anywhere else
https://review.coreboot.org/c/coreboot/+/45742/6/src/mainboard/google/voltee... PS6, Line 177: : ret = google_chromeec_usb_get_pd_mux_info(i, &mux_flags); : if (ret < 0) { : printk(BIOS_ERR, "port C%d: get_pd_mux_info failed\n", i); : continue; : } ``` if (google_chromeec_usb_get_pd_mux_info(i, &mux_flags) < 0) { printk(BIOS_ERR, "port C%d: get_pd_mux_info failed\n", i); continue; } ```
? ret isn't used anywhere else
https://review.coreboot.org/c/coreboot/+/45742/6/src/mainboard/google/voltee... PS6, Line 184: ret = google_chromeec_usb_pd_control(i, &ufp, &acc, &dp_mode); : if (ret < 0) { : printk(BIOS_ERR, "port C%d: pd_control failed\n", i); : continue; : } ``` if (google_chromeec_usb_pd_control(i, &ufp, &acc, &dp_mode) < 0) { printk(BIOS_ERR, "port C%d: pd_control failed\n", i); continue; } ``` ? ret isn't used anywhere else