Attention is currently required from: Bora Guvendik, Cliff Huang.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84392?usp=email )
Change subject: soc/intel/common/block/acpi: Fix GPE1 blocks to ACPI FADT table
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/84392/comment/11e5304f_21ab6cdf?usp... :
PS4, Line 96: bool "SOC to use GPE1 Event approach"
please don't use the prompt, just `bool` is enough […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84392?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd8115044faff3161ea6bd1cae6c0fe8aa0ff8d7
Gerrit-Change-Number: 84392
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:17:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com