Attention is currently required from: Arthur Heymans, Tim Wawrzynczak, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59362 )
Change subject: soc/intel/alderlake: Define the helper functions
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/59362/comment/539a7373_e03b24cb
PS3, Line 88: TRUE
no UEFI types please
Done
File src/soc/intel/alderlake/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/59362/comment/76aea55d_27134aea
PS3, Line 34: uint8_t get_cpu_type(void);
this belongs in a different CL
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I963690a4fadad322095d202bcc08c92dcd845360
Gerrit-Change-Number: 59362
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 29 Nov 2021 19:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-MessageType: comment