Attention is currently required from: Cliff Huang, Subrata Banik (OOO till 10/18).
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84718?usp=email )
Change subject: mb/google/fatcat: add pre-mem GPIO pad configure based on fw_config ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84718/comment/2631627c_a9b8c063?usp... : PS4, Line 7: dd pre-mem GPIO pad configure based on fw_config
Since you've added more devices in this CL than the pre-mem device usage, I don't think this commit […]
I am confused, we followed https://review.coreboot.org/c/coreboot/+/84718/comments/0401046a_46026bbd and as a result we pulled a bit from overridetree.cb to satisfy your request.
The commit message still is about configuring GPIO based on fw_config but having these changes without the device which go away do not make sense.
Do you mean we should add a line stating that we are also providing the devicetree information for the relevant devices ?