Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76026?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableFivr dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableFivr dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="FastPkgCRampDisableFivr" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I453fe56a127d1c870dd0e24ed4cbd33c9f3a00a4 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/purism/librem_cnl/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/76026/1
diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb index e3d93f4..b75b579 100644 --- a/src/mainboard/purism/librem_cnl/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/devicetree.cb @@ -14,7 +14,7 @@ register FastPkgCRampDisableIa = true register FastPkgCRampDisableGt = true register FastPkgCRampDisableSa = true - register "FastPkgCRampDisableFivr" = "1" + register FastPkgCRampDisableFivr = true
register "SlowSlewRateForIa" = "3" # fast/16 register "SlowSlewRateForGt" = "3" # fast/16