Attention is currently required from: Bob Moragues, Bob Moragues, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change by Bob Moragues. ( https://review.coreboot.org/c/coreboot/+/82630?usp=email )
Change subject: mainboard/google/brox: Add FW_CONFIG and SKU definitions to support lotso ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82630/comment/aee13149_9d09a0c8?usp... : PS3, Line 19: option AUDIO_REALTEK_ALC3287 2
I believe this was included to simply keep the the bit fields aligned between the brox reference des […]
Yeah, as Shelley pointed out each variant can have its own FW_CONFIG and hence no need to align them.
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82630/comment/b7542be1_83a7b229?usp... : PS1, Line 31: hip soc/intel/alderlake : : device domain 0 on : end : : end
Should this be removed?
Your CL has a merge conflict. Probably you need to rebase on top of the coreboot tree. Also the update you are trying to do has already been done here by the ODM team - https://review.coreboot.org/c/coreboot/+/83051