[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
PS8, Line 99: static
> Why is this static?

I think it is static because the address of hash_digest buffer from the response is returned/assigned to **hash parameter.

I am not sure if it cannot be copied over instead of returning the address.

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
PS8, Line 119: (recalc_requested)
Since we have set EC_VBOOT_HASH_STATUS_BUSY and checking against that explicitly, at what point is this check required?