Attention is currently required from: Felix Singer, Tim Crawford, Tim Wawrzynczak, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56862 )
Change subject: soc/intel/tgl: Add ucode for TGL-U and TGL-R
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56862/comment/e3a1e04d_52decc98
PS3, Line 7: Add
I'd prefer `Hook up` here, as it is more accurate
https://review.coreboot.org/c/coreboot/+/56862/comment/d4cfe429_d702e5a6
PS3, Line 9: Add
Same as above
https://review.coreboot.org/c/coreboot/+/56862/comment/fa4d2b22_096255c0
PS3, Line 10: - 06-8c-01 (CPUID signature: 0x806c1)
: - 06-8c-02 (CPUID signature: 0x806c2)
Do you know which one is TGL-U and which one is TGL-R? If so, I'd add this information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I210c0133dad7ade63b9f7177aaa9a69b019469af
Gerrit-Change-Number: 56862
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 10 Aug 2021 09:23:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment