Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33796 )
Change subject: asus/am1i-a: Fix UART 0 port while preserving UART 1 functionality
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33796/3/src/mainboard/asus/am1i-a/romstage.c
File src/mainboard/asus/am1i-a/romstage.c:
https://review.coreboot.org/#/c/33796/3/src/mainboard/asus/am1i-a/romstage.c...
PS3, Line 29: CONFIG_TTYS0_BASE
use CONFIG_UART_FOR_CONSOLE
Done
You may also want to make sure it does not compile if an invalid CONFIG_UART_FOR_CONSOLE is set.
Please could you advise the best way how to do this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6579aa8fd092da84f8afdcc33496db45c582919f
Gerrit-Change-Number: 33796
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 26 Jun 2019 18:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment