Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36068 )
Change subject: automation: update script and template files for new variant
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
File util/mainboard/google/hatch/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
PS5, Line 21: #define GPIO_MEM_CONFIG_0 GPP_F20
hmm. […]
It is there just to make the code compile. A new variant in coreboot starts out as just a clone of the baseboard, so this will match up with the Hatch definitions.
It would be nice to have them defined at the baseboard level, and then if the variant hasn't changed the GPIOs for memory configuration, no need to do anything. That's a future project.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1
Gerrit-Change-Number: 36068
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 24 Oct 2019 12:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Gerrit-MessageType: comment