[coreboot-gerrit] [S] Change in coreboot[master]: cpu/intel/speedstep: Refactor P-state coordination

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74398 )

Change subject: cpu/intel/speedstep: Refactor P-state coordination
......................................................................

cpu/intel/speedstep: Refactor P-state coordination

Change-Id: I12462f271821d3d8fe3324d84a65c2341729591e
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/intel/speedstep/acpi.c
1 file changed, 22 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/74398/1

diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c
index acca77e..0d2cc87 100644
--- a/src/cpu/intel/speedstep/acpi.c
+++ b/src/cpu/intel/speedstep/acpi.c
@@ -60,6 +60,16 @@
    acpigen_write_PPC(0);
 }

+static uint8_t get_p_state_coordination(void)
+{
+	/* For Penryn use HW_ALL. */
+	if (((cpuid_eax(1) >> 4) & 0xffff) == 0x1067)
+		return HW_ALL;
+
+	/* Use SW_ANY as that was the default. */
+	return SW_ANY;
+}
+
 /**
  * @brief Generate ACPI entries for Speedstep for each cpu
  */
@@ -71,22 +81,17 @@
    int numcpus = totalcores/cores_per_package; /* This assumes that all
    					       CPUs share the same
    					       layout. */
+
    int num_cstates;
    const acpi_cstate_t *cstates;
    sst_table_t pstates;
-	uint8_t coordination;
+	uint8_t coordination = get_p_state_coordination();

printk(BIOS_DEBUG, "Found %d CPU(s) with %d core(s) each.\n",
           numcpus, cores_per_package);

num_cstates = get_cst_entries(&cstates);
    speedstep_gen_pstates(&pstates);
-	if (((cpuid_eax(1) >> 4) & 0xffff) == 0x1067)
-		/* For Penryn use HW_ALL. */
-		coordination = HW_ALL;
-	else
-		/* Use SW_ANY as that was the default. */
-		coordination = SW_ANY;

for (cpuID = 0; cpuID < numcpus; ++cpuID) {
    	for (coreID = 1; coreID <= cores_per_package; coreID++) {