Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44672 )
Change subject: vc/google/chromeos: load wifi_sar_defaults.hex as the main WiFi SAR CBFS source ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44672/3/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/44672/3/src/vendorcode/google/chrom... PS3, Line 116: return WIFI_SAR_CBFS_FILENAME;
We can skip it if you want. […]
I think it's good to have that safe guard (so that implementations of this function can return NULL and things don't explode on us).
We can _also_ make it more explicit here for robustness and clarity (in that it's immediately obvious that this file name is used), I was just curious if there's a particular reason to add that here because I couldn't see anything. I suspect that the code impact is a single address load since the string is already present, with should be ~5 bytes, so *shrug*? :-)