[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29032 )

Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
......................................................................

mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On

Port commit f1395d82: "ec/lenovo/h8: Add USB Always On" to the Thinkpad
x1_carbon_gen1 board as well, as it seems to work fine on all
generations.

See also commit 7ffb329f with Change-Id
I6dcbfaae2a444d9a679ecb64a87dc2a59b8fd281 ("mb/lenovo/*/cmos: Port USB
Always On").

Note that we don't need to call h8_usb_always_on() directly since commit
4f4322dd with Change-Id If812cd1ef8fb1a24d7fadbe834f574b40cbcd56a
("lenovo/h8,thinkpads: Re-do USB Always On").

Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25
Signed-off-by: Patrick Rudolph 
Signed-off-by: Peter Lemenkov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/29032
Tested-by: build bot (Jenkins) 
Reviewed-by: Nicola Corna 
---
M src/mainboard/lenovo/x1_carbon_gen1/cmos.default
M src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Rudolph: Looks good to me, approved
  Nicola Corna: Looks good to me, but someone else must approve

diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default
index 3044c6c..979f132 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default
+++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default
@@ -13,3 +13,4 @@
 sticky_fn=Disable
 trackpoint=Enable
 backlight=Both
+usb_always_on=Disable
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
index ad5a489..bb25261 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
+++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
@@ -67,7 +67,7 @@
 416         1       e       1        trackpoint
 417         1       e       1        fn_ctrl_swap
 418         1       e       1        sticky_fn
-#419        2       r       0        unused
+419         2       e      12        usb_always_on
 421         1       e       9        sata_mode
 422         2       e      10        backlight

@@ -126,6 +126,9 @@
 11    4     160M
 11    5     192M
 11    6     224M
+12    0     Disable
+12    1     AC and battery
+12    2     AC only

# -----------------------------------------------------------------
 checksums